Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle complex structs in metadata #215

Merged
merged 4 commits into from
Mar 1, 2024
Merged

Handle complex structs in metadata #215

merged 4 commits into from
Mar 1, 2024

Conversation

DariaKunoichi
Copy link
Contributor

@DariaKunoichi DariaKunoichi commented Feb 23, 2024

Goal

New fields with complex struct types in metadata could not be properly processed and resulted in "{}" in output.

Design

Changeset

Added handling for known complex types like date and time, errors, stringers.

Testing

Unit tests added.

Copy link
Contributor

@tomlongridge tomlongridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, with a CHANGELOG entry

@DariaKunoichi DariaKunoichi merged commit d00bba9 into next Mar 1, 2024
53 checks passed
@DariaKunoichi DariaKunoichi deleted the daria-PLAT-11545 branch March 1, 2024 09:44
@DariaKunoichi DariaKunoichi mentioned this pull request Mar 5, 2024
DariaKunoichi added a commit that referenced this pull request Mar 5, 2024
## 2.3.0 (2024-03-05)

### Bug fixes

* Start showing inlined functions in stack trace
  [#208](#208)

* Handle complex structs in metadata
  [#215](#215)
  [Chris Duncan](https://github.com/veqryn)

* Stop trimming everything before "main.go" on main packages
  [#217](#217)
  [Chris Duncan](https://github.com/veqryn)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants